impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Impala ABM / LZCNT support
Date Sun, 29 Jan 2017 19:40:36 GMT
Marcel Kornacker has posted comments on this change.

Change subject: Impala ABM / LZCNT support
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5821/1/be/src/util/bit-util.h
File be/src/util/bit-util.h:

Line 98:   static inline uint32_t RoundUpToPowerOfTwoNoHw32(uint32_t v) {
> One of the primary reasons I created this change was to probe exactly that 
let's discuss in person, but i think the function should be careful about bounds, not the
caller. also, impala doesn't support unsigned column types, so there isn't really a need for
unsigned arithmetic on user data.


-- 
To view, visit http://gerrit.cloudera.org:8080/5821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6a465ab4a9ee4f582847f8e211a779bdede3d2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message