impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.
Date Fri, 27 Jan 2017 21:16:36 GMT
John Russell has posted comments on this change.

Change subject: [DOCS] Add doc for MT_DOP query option.
......................................................................


Patch Set 4:

(6 comments)

I made comments for changes based on discussion with Mostafa.

http://gerrit.cloudera.org:8080/#/c/5652/4/docs/topics/impala_mt_dop.xml
File docs/topics/impala_mt_dop.xml:

PS4, Line 94: These timing figures
Reword since I'm going to take out some of the timing figures, so not every example will have
'em.


PS4, Line 100: a speedup for
how to run ... COMPUTE STATS ...

The COUNT(DISTINCT) is in a separate example now so don't mention it here.


PS4, Line 118: Fetched 1 row(s) in 7.55s
Mostafa suggestion: Take out timing info.


PS4, Line 122: cores
Mostafa suggestion: "logical processors"


PS4, Line 132: Fetched 1 row(s) in 4.53s
Mostafa suggestion: Take out timing info.


PS4, Line 148: Fetched 1 row(s) in 4.53s
Mostafa suggestion: Take out timing info.


-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message