impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Updates to DML statements for Impala + Kudu
Date Fri, 27 Jan 2017 20:57:10 GMT
Matthew Jacobs has posted comments on this change.

Change subject: Updates to DML statements for Impala + Kudu
......................................................................


Patch Set 5: Code-Review+2

(2 comments)

Please just address my comment about arbitrary, otherwise looks good- thanks!

http://gerrit.cloudera.org:8080/#/c/5646/5/docs/topics/impala_delete.xml
File docs/topics/impala_delete.xml:

PS5, Line 42: arbitrary 
this makes it sound like it's random. how about 'a number of rows' or 'one or more' rows?


http://gerrit.cloudera.org:8080/#/c/5646/4/docs/topics/impala_upsert.xml
File docs/topics/impala_upsert.xml:

PS4, Line 41: <indexterm audience="hidden">UPSERT statement</indexterm>
            :       Acts as a combination of the <codeph>INSERT</codeph>
            :       and <codeph>UPDATE</codeph> statements.
> It is pretty well-known for people familiar with UPSERT (i.e. implied by th
It's just kind of ambiguous as to what that means. Anyway I don't feel that strongly.


-- 
To view, visit http://gerrit.cloudera.org:8080/5646
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60512b7957fb53d86d3123a4f1d46fbb355f4665
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcryans@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <todd@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message