impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4820: avoid writing unencrypted data during write cancellation
Date Thu, 26 Jan 2017 20:41:51 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5788/1//COMMIT_MSG
Commit Message:

Since this is a security issue, maybe worth noting when this was introduced here.


http://gerrit.cloudera.org:8080/#/c/5788/1/be/src/common/global-flags.cc
File be/src/common/global-flags.cc:

Line 94: // Stress option for testing failed memory allocation. Debug builds only.
This comment seems weird, since it looks like it applies to the whole #ifndef block, but its
really just referring to the first one.

Maybe update it to "Stress options for debug builds only", or even just remove it.


-- 
To view, visit http://gerrit.cloudera.org:8080/5788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I956bae0685e863f30be23634b29aa076394db184
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message