impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page
Date Thu, 26 Jan 2017 18:49:40 GMT
Matthew Jacobs has posted comments on this change.

Change subject: [DOCS] Major update to Impala + Kudu page
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5649/11/docs/topics/impala_create_table.xml
File docs/topics/impala_create_table.xml:

PS11, Line 81: CREATE [EXTERNAL] TABLE [IF NOT EXISTS] [<varname>db_name</varname>.]<varname>table_name</varname>
             :   (<varname>col_name</varname> <varname>data_type</varname>
             :     <ph rev="kudu IMPALA-3719">[<varname>kudu_column_attribute</varname>
...]</ph>
             :     [COMMENT '<varname>col_comment</varname>']
             :     [, ...]
             :     [PRIMARY KEY (<varname>col_name</varname>[, ...]]
             :   )
             :   [PARTITIONED BY (<varname>col_name</varname> <varname>data_type</varname>
[COMMENT '<varname>col_comment</varname>'], ...)]
             :   [COMMENT '<varname>table_comment</varname>']
             :   [WITH SERDEPROPERTIES ('<varname>key1</varname>'='<varname>value1</varname>',
'<varname>key2</varname>'='<varname>value2</varname>', ...)]
             :   <ph rev="kudu">[PARTITION BY <varname>kudu_partition_clause</varname></ph>
             :   [
             :    [ROW FORMAT <varname>row_format</varname>] [STORED AS <varname>file_format</varname>]
             :   ]
             :   [LOCATION '<varname>hdfs_path</varname>']
> I think we can improve the syntax definition to avoid common mistakes and c
I'm fine with not trying to put HDFS and Kudu tables together, or Dimitris' suggestion above.


-- 
To view, visit http://gerrit.cloudera.org:8080/5649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76dcb948dab08532fe41326b22ef78d73282db2c
Gerrit-PatchSet: 11
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcryans@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <todd@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message