impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".
Date Thu, 26 Jan 2017 17:57:34 GMT
Dan Hecht has posted comments on this change.

Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan".
......................................................................


Patch Set 4:

(1 comment)

> (4 comments)
 > 
 > Just a few minor things from my point of view.
 > 
 > It seems like there was some discussion around the best way to do
 > the casts (i.e. whether to just use the builtin cast operators). I
 > think the current approach works nicer inside templated functions
 > because there's less boilerplate like make_unsigned.

The discussion was around using lambdas to deal with the operations where the input and output
needs to be casted, not whether cast operator itself is wrapped. I'm good with wrapping the
cast and typedef. 

Will take a look shortly.

http://gerrit.cloudera.org:8080/#/c/5082/4/be/src/exec/exec-node.cc
File be/src/exec/exec-node.cc:

Line 434:     if (mem_tracker_ != nullptr) {
can mem_tracker_ actually be null here?


-- 
To view, visit http://gerrit.cloudera.org:8080/5082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88c7234bd7c5eb7404490a0913d90470c10835e7
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message