impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.
Date Wed, 25 Jan 2017 23:25:47 GMT
Hello Jim Apple, Michael Ho,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5791

to look at the new patch set (#5).

Change subject: IMPALA-4055: Speed up to_date() with custom implementation.
......................................................................

IMPALA-4055: Speed up to_date() with custom implementation.

Simple implementation of to_date() that avoids calling
into boost for a speedup of 10x.

Perf:
I generated a synthetic Parquet table with 26437248 rows
and a single timestamp column. I tested the response time
of the following query before and after this change.

set mt_dop=1;
select count(*) from to_date_test
where to_date(ts) = '2017-10-23';

Before: 38.1s
After:   3.4s

Testing: I locally ran expr-test.cc and expr_test.py.

Change-Id: I5713b3e0c27b739aae597a6911cf3b2ddd01f822
---
M be/src/exprs/timestamp-functions-ir.cc
M be/src/exprs/timestamp-functions.cc
M be/src/exprs/timestamp-functions.h
M tests/conftest.py
4 files changed, 25 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/5791/5
-- 
To view, visit http://gerrit.cloudera.org:8080/5791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5713b3e0c27b739aae597a6911cf3b2ddd01f822
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>

Mime
View raw message