impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4750: Rename test infra classes so they don't mimic test classes.
Date Wed, 25 Jan 2017 20:35:30 GMT
David Knupp has posted comments on this change.

Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5794/1/tests/experiments/test_targeted_perf.py
File tests/experiments/test_targeted_perf.py:

PS1, Line 33: TestMatrix
> I think it's best to figure out who or what runs this file before committin
OK, I'll send email out to the team.

FWIW, if you run these tests, they (mostly) don't pass either. Given thir location, failures,
and the fact that this file hasn't been touched since 2013, I feel pretty sure this is dead
code.


-- 
To view, visit http://gerrit.cloudera.org:8080/5794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06b7bc6fd99fbb637a47ba376bf9830705c1fce1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message