impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <>
Subject [Impala-ASF-CR] MPALA-4750: Rename test infra classes so they don't mimic test classes.
Date Wed, 25 Jan 2017 20:19:40 GMT
David Knupp has posted comments on this change.

Change subject: MPALA-4750: Rename test infra classes so they don't mimic test classes.

Patch Set 1:


I did check that the same number of tests were collected (note -- that there is parallel change
required for the tests in the aux directory that will be submitted as well.)

These are the numbers, correcting for the problem with test_cancel_insert (IMPALA-4818).

  $ grep collected ~/tmp/pytest_collect_core*
  /home/dknupp/tmp/pytest_collect_core_IMPALA4750.txt:collecting ... collected 1830 items
/ 5 skipped
  /home/dknupp/tmp/pytest_collect_core_master.txt:collecting ... collected 1830 items / 5

  $ grep collected ~/tmp/pytest_collect_exhaustive*
  /home/dknupp/tmp/pytest_collect_exhaustive_IMPALA4750.txt:collecting ... collected 20881
  /home/dknupp/tmp/pytest_collect_exhaustive_master.txt:collecting ... collected 20881 items
Commit Message:

PS1, Line 7: MPALA
> Don't forget I.

PS1, Line 9: that
> extra word
File tests/experiments/

PS1, Line 33: TestMatrix
> What's going on here?
Weird. I don't know how that happened.

For what it's worth, tests/experiments is not in the white list of directories defined in, so these tests never get run.

Also, the name of the classmethod is even wrong -- add_test_dimensions() should be plural.
So even if you try to run the tests in this module explicitly, this code still doesn't get

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I06b7bc6fd99fbb637a47ba376bf9830705c1fce1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <>
Gerrit-Reviewer: David Knupp <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-HasComments: Yes

View raw message