impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] MPALA-4750: Rename test infra classes so they don't mimic test classes.
Date Wed, 25 Jan 2017 19:32:56 GMT
Jim Apple has posted comments on this change.

Change subject: MPALA-4750: Rename test infra classes so they don't mimic test classes.
......................................................................


Patch Set 1:

(2 comments)

You checked that the same tests are selected to be run both before and after this patch?

http://gerrit.cloudera.org:8080/#/c/5794/1//COMMIT_MSG
Commit Message:

PS1, Line 9: that
extra word


http://gerrit.cloudera.org:8080/#/c/5794/1/tests/experiments/test_targeted_perf.py
File tests/experiments/test_targeted_perf.py:

PS1, Line 33: TestMatrix
What's going on here?


-- 
To view, visit http://gerrit.cloudera.org:8080/5794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06b7bc6fd99fbb637a47ba376bf9830705c1fce1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message