impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.
Date Wed, 25 Jan 2017 17:20:20 GMT
Jim Apple has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
......................................................................


Patch Set 8:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5667/8//COMMIT_MSG
Commit Message:

Line 25: Comments on blog posts is being handled via Disqus. Other than that, not a
long line


http://gerrit.cloudera.org:8080/#/c/5667/4/nikola_site_generator/README.md
File nikola_site_generator/README.md:

PS4, Line 44: packages listed in the ```requirements.txt``
> You'd probably have to sudo it, but yeah.
Can you add a note to that effect?


Line 74: You shoud have an empty dated template now that you can fill in.
> The slug is the human-readable last portion of the permalink for a post. E.
Can you add a note to that effect?


-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message