impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <>
Subject [Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.
Date Wed, 25 Jan 2017 07:27:21 GMT
David Knupp has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.

Patch Set 4:

File nikola_site_generator/

Line 18: You will need to install a few python packages to work with Nikola. It's up to you
whether you
> Can you word wrap at 90 characters like in the Java and C++ source code?

PS4, Line 44: (blog_env) $ pip install -r requirements.txt
> This is the only line I need if I don't wish to use a virtualenv, right?
You'd probably have to sudo it, but yeah.

Line 74: .. slug: my-new-post
> What is a slug?
The slug is the human-readable last portion of the permalink for a post. E.g., if my blog
post is titled "Apache Kudu and Apache Impala (Incubating): The Integration Roadmap", I might
want to have the slug be something like "kudu-impala-integration-roadmap", making the permalink
to the article:

PS4, Line 110: ``TEASER_END```
> mismatched number of backticks

PS4, Line 163: browser
> I think I can also just point my browser at the .html files with "file:///.
Apparently so. In my experience, it's usually better to run a simple development server, but
maybe that's because I've done more with dynamically generated sites. In this case, it seems
not to matter.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp <>
Gerrit-Reviewer: David Knupp <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-HasComments: Yes

View raw message