impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mostafa Mokhtar (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step
Date Tue, 24 Jan 2017 01:40:10 GMT
Mostafa Mokhtar has posted comments on this change.

Change subject: IMPALA-3748: add query-wide resource acquisition step
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5739/6/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:

Line 83:     prepare_status_ = process_mem_tracker->MemLimitExceeded(NULL, msg, 0);
> What happens when mem limit is exceeded on one Impalad?
And how is this integrating with admission control? Ideally if the query is admitted it shouldn't
fail on acquiring min reservation.


-- 
To view, visit http://gerrit.cloudera.org:8080/5739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia21a3c0f0b0a7175116883ef9871b93c8ce8bb81
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message