impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker
Date Mon, 23 Jan 2017 23:10:26 GMT
Hello Thomas Tauber-Marshall,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5772

to look at the new patch set (#2).

Change subject: IMPALA-4801: fix heap use after free for MemTracker
......................................................................

IMPALA-4801: fix heap use after free for MemTracker

This is a minimal fix for IMPALA-4801. The bug was that
"IMPALA-4678: move query MemTracker into QueryState" changed
the lifecycle of RuntimeState::instance_mem_tracker_ so that
it destroyed earlier in ReleaseResources(). A periodic
counter referencing the MemTracker was only stopped after
ReleaseResources() was called, leaving a window for a race.

There are various issues with the lifecycle of RuntimeProfile
objects (see IMPALA-4802) but I chose not to tackle them in
this patch.

Change-Id: Iccaf6700888c333b9c93d716d395d96bc5af6631
---
M be/src/runtime/plan-fragment-executor.cc
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/5772/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iccaf6700888c333b9c93d716d395d96bc5af6631
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>

Mime
View raw message