impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step
Date Mon, 23 Jan 2017 22:51:34 GMT
Hello Marcel Kornacker,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5739

to look at the new patch set (#5).

Change subject: IMPALA-3748: add query-wide resource acquisition step
......................................................................

IMPALA-3748: add query-wide resource acquisition step

This adds a Prepare() method to QueryState that allows
query execution to fail up-front if resources cannot be
acquired. We don't make full use of this yet, but it
provides a suitable place to acquire a memory reservation
for the query or fail cleanly.

The process memory limit check is moved here so that all
startup memory checks will be eventually consolidated in
one place.

Also switch a boost::mutex to a SpinLock for consistency
and to improve performance (see lock-benchmark.cc).

Change-Id: Ia21a3c0f0b0a7175116883ef9871b93c8ce8bb81
---
M be/src/runtime/query-exec-mgr.cc
M be/src/runtime/query-exec-mgr.h
M be/src/runtime/query-state.cc
M be/src/runtime/query-state.h
M be/src/runtime/test-env.cc
5 files changed, 58 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/5739/5
-- 
To view, visit http://gerrit.cloudera.org:8080/5739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia21a3c0f0b0a7175116883ef9871b93c8ce8bb81
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message