impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker
Date Mon, 23 Jan 2017 22:49:37 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4801: fix heap use after free for MemTracker
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5772/1/be/src/runtime/plan-fragment-executor.cc
File be/src/runtime/plan-fragment-executor.cc:

PS1, Line 511:   // Sanity timer checks
             : #ifndef NDEBUG
             :   int64_t total_time = profile()->total_time_counter()->value();
             :   int64_t other_time = 0;
             :   for (auto& name: {PREPARE_TIMER_NAME, OPEN_TIMER_NAME, EXEC_TIMER_NAME})
{
             :     RuntimeProfile::Counter* counter = timings_profile_->GetCounter(name);
             :     if (counter != nullptr) other_time += counter->value();
             :   }
             :   DCHECK_LE(other_time, total_time);
             : #endif
just put everything before release resources? even if timings_profile_ doesn't ref runtime_state_,
it'd be easier to reason about this method if l508 and l509 were at the end


-- 
To view, visit http://gerrit.cloudera.org:8080/5772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iccaf6700888c333b9c93d716d395d96bc5af6631
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message