impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen
Date Mon, 23 Jan 2017 22:38:32 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5732/2/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:

Line 194:         if (IsDefinedInImpalad(fn_name)) continue;
> Sounds reasonable - I think we just need some comments explaining it
Done


http://gerrit.cloudera.org:8080/#/c/5732/2/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

Line 63: DECLARE_bool(fe_support_disable_codegen);
> I don't think we want to expose this as a command-line option, do we?
Moved to a static flag in fe-support.cc and it's initialized via InitFeSupport().


http://gerrit.cloudera.org:8080/#/c/5732/1/be/src/exprs/timestamp-functions-ir.cc
File be/src/exprs/timestamp-functions-ir.cc:

Line 57
> I agree it probably doesn't matter too much, but we should generally just p
Done


http://gerrit.cloudera.org:8080/#/c/5732/2/be/src/exprs/timestamp-functions.h
File be/src/exprs/timestamp-functions.h:

Line 42:   static const int64_t MAX_YEAR_INTERVAL;
> I think we should define the constant values here, so that they can be inli
Done. Btw, the old definition of MAX_MINUTE_INTERVAL is smaller than it should be. The new
patch has the right value.


-- 
To view, visit http://gerrit.cloudera.org:8080/5732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40fdb035a565ae2f9c9fbf4db48a548653ef7608
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message