impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Attila Jeges (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files
Date Fri, 20 Jan 2017 16:18:33 GMT
Attila Jeges has posted comments on this change.

Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files

Patch Set 8:

File common/thrift/

PS8, Line 315: is poorly formatted
> this seems a bit strong and can be misinterpreted as in the file results in

PS8, Line 319: fs.s3a.block.size
> this is a global option, though, so it might not be possible to match the s

I'm not sure what is the proper way to get fs.s3a.block.size/dfs.blocksize values. Is there
some sample code that I could look at?
File tests/query_test/

Line 314:   @SkipIfS3.hdfs_block_size
> why not make this test work for S3?

PS8, Line 327: hdfs://localhost:20500
> this (and other places) won't work for S3 (and other non-hdfs) test setups.
I could not find filesystem_prefix() method.

I was thinking about using FILESYSTEM_PREFIX but it is set to empty string when running queries
against the default fs.  NAMENODE seems to be working here.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf48d978383d73efdade733a892e795ebd53c76a
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <>
Gerrit-Reviewer: Attila Jeges <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-HasComments: Yes

View raw message