impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Attila Jeges (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files
Date Fri, 20 Jan 2017 16:18:33 GMT
Attila Jeges has posted comments on this change.

Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files
......................................................................


Patch Set 8:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5400/8/common/thrift/generate_error_codes.py
File common/thrift/generate_error_codes.py:

PS8, Line 315: is poorly formatted
> this seems a bit strong and can be misinterpreted as in the file results in
Done


PS8, Line 319: fs.s3a.block.size
> this is a global option, though, so it might not be possible to match the s
Done.

I'm not sure what is the proper way to get fs.s3a.block.size/dfs.blocksize values. Is there
some sample code that I could look at?


http://gerrit.cloudera.org:8080/#/c/5400/8/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

Line 314:   @SkipIfS3.hdfs_block_size
> why not make this test work for S3?
Done


PS8, Line 327: hdfs://localhost:20500
> this (and other places) won't work for S3 (and other non-hdfs) test setups.
I could not find filesystem_prefix() method.

I was thinking about using FILESYSTEM_PREFIX but it is set to empty string when running queries
against the default fs.  NAMENODE seems to be working here.


-- 
To view, visit http://gerrit.cloudera.org:8080/5400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf48d978383d73efdade733a892e795ebd53c76a
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message