impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext
Date Fri, 20 Jan 2017 02:46:27 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4192: Disentangle Expr and ExprContext
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5483/4/be/src/exec/hash-table-test.cc
File be/src/exec/hash-table-test.cc:

Line 74:     ASSERT_OK(ExprContext::Prepare(build_expr_ctxs_, NULL, desc, &tracker_))
Missing semi-colon. Should have compiled the tests too.


http://gerrit.cloudera.org:8080/#/c/5483/4/be/src/exprs/expr.cc
File be/src/exprs/expr.cc:

Line 376: Status Expr::Prepare(RuntimeState* state, const RowDescriptor& row_desc) {
> It's kind of weird that the scope of what is initialised is different for E
Good point. I like OpenContext() and CloseContext().


-- 
To view, visit http://gerrit.cloudera.org:8080/5483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefdc9aeeba033355cb9497e3a5d2363627dcf2f3
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message