impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4775: minor adjustments to python test infra logging
Date Fri, 20 Jan 2017 02:24:48 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4775: minor adjustments to python test infra logging
......................................................................


IMPALA-4775: minor adjustments to python test infra logging

- Set up log handler to append, not truncate. This was the cause of
  IMPALA-4775.

Other improvements:
- Log a thread name, not thread ID. Thread names are more useful.
- Use ISO 8601-like timestamps

I tested that running disrepancy_searcher.py doesn't overwrite its logs
anymore. One such command that could reproduce it is:

tests/comparison/discrepancy_searcher.py \
  --use-postgresql \
  --query-count 1 \
  --db-name tpch_kudu

I also ensured the stress test (concurrent_select.py) still logged to
its file.

Change-Id: I2b7af5b2be20f3c6f38d25612f6888433c62d693
Reviewed-on: http://gerrit.cloudera.org:8080/5746
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/comparison/cli_options.py
M tests/comparison/discrepancy_searcher.py
M tests/stress/concurrent_select.py
3 files changed, 11 insertions(+), 9 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b7af5b2be20f3c6f38d25612f6888433c62d693
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>

Mime
View raw message