impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step
Date Fri, 20 Jan 2017 01:02:27 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-3748: add query-wide resource acquisition step
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5739/3/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 468:   RETURN_IF_ERROR(query_state_->PrepareForExecution());
actually, this won't work in the future: to do meaningful preparation, you'll need the full
set of fragment instances in front of you (in particular for meaningful reservation; trying
to do it as fragment instances trickle in is going to be needlessly complicated).

i'm wondering if this needs to wait until the per-query exec rpc is in.


-- 
To view, visit http://gerrit.cloudera.org:8080/5739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia21a3c0f0b0a7175116883ef9871b93c8ce8bb81
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message