impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step
Date Fri, 20 Jan 2017 00:51:16 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-3748: add query-wide resource acquisition step
......................................................................


Patch Set 3: Code-Review+2

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5739/3/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:

Line 53:   InitMemTrackers(pool);
move to prepare


Line 68:   if (prepared_) return Status::OK();
in that case prepared_status_ should also be ok; add a dcheck


Line 72:   // Starting a new fragment instance creates a thread and consumes a non-trivial
rephrase; this isn't called per instance


http://gerrit.cloudera.org:8080/#/c/5739/3/be/src/runtime/query-state.h
File be/src/runtime/query-state.h:

Line 102:   Status PrepareForExecution();
Prepare() (what else would it prepare for?)


-- 
To view, visit http://gerrit.cloudera.org:8080/5739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia21a3c0f0b0a7175116883ef9871b93c8ce8bb81
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message