impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog
Date Thu, 19 Jan 2017 23:52:31 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4449: Revisit table locking pattern in the catalog

Patch Set 3:

File fe/src/main/java/org/apache/impala/catalog/

Line 184:   // TODO: Make this parameter configurable
why? we want to restructure the entire object and locking hierarchy anyway.

Line 185:   private static final long TBL_LOCK_TIMEOUT_MS = 3600000;
this is still an hour. i don't think that's a reasonable timeout value.

Line 977:       tbl.getLock().unlock();
could you add a precondition into all of the finally branches that make sure that the catalog
lock isn't being held?
File fe/src/main/java/org/apache/impala/service/

Line 194:  * Note: The getCatalogObjects() function is the only case where this locking pattern
it's not the only case *in principle* (maybe it is right now), because every operation that
needs to touch multiple tables would also need a different locking pattern.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Id08e21da31deb1f003b3cada4517651f3b3b2bb2
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-HasComments: Yes

View raw message