impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
Date Thu, 19 Jan 2017 22:57:00 GMT
Jim Apple has submitted this change and it was merged.

Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
......................................................................


IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks

RECOVER PARTITIONS needs to avoid recovering partitions that are
already in HMS. Before this patch, that check is done by makeing a
list of the existing partitions and searching in that list for each
path found in the search for partitions eligible for recovery. This
patch changes the container to a HashSet for performance reasons.

Change-Id: I4b9b6f8eb85f854e8c0896c18a231cebe32b4678
Reviewed-on: http://gerrit.cloudera.org:8080/5745
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Reviewed-by: Marcel Kornacker <marcel@cloudera.com>
Tested-by: Jim Apple <jbapple-impala@apache.org>
---
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Marcel Kornacker: Looks good to me, approved
  Jim Apple: Verified
  Alex Behm: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.cloudera.org:8080/5745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b9b6f8eb85f854e8c0896c18a231cebe32b4678
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>

Mime
View raw message