impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <>
Subject [Impala-ASF-CR] Release note updates for Impala 2.8
Date Wed, 18 Jan 2017 21:01:26 GMT
Jim Apple has posted comments on this change.

Change subject: Release note updates for Impala 2.8

Patch Set 3:

File docs/topics/impala_incompatible_changes.xml:

Line 56:   <concept rev="2.8.0" id="incompatible_changes_28x">
Have you checked that these changes are all in the 2.8.0 release candidate 1 that the IPMC
is voting on right now?

PS3, Line 58: Impala Incompatible Changes Introduced in Impala 2.8.x
This wording is surprising to me. Why is the first word needed at all?

Line 65:             They were output in uppercase by mistake, but only for a single Impala
release (Impala 2.7).
It makes changes easier to review when the lines are 90 characters or fewer.

PS3, Line 111:  
space at end of line

Line 112:             non-primary-key olumns had the <codeph>NOT NULL</codeph>
attribute by default.

Line 1523:   <concept id="incompatible_changes_07" audience="hidden">
Why hide this?
File docs/topics/impala_new_features.xml:

PS3, Line 53: / CDH 5.10.x
Please remove.

Line 84:                 The <codeph>MT_DOP</codeph> query option enables
The line breaks here are sometimes around 80 characters, and sometimes over 90.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c47f422e509cec6d3eb8aaa82294b584f393aed
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Ambreen Kazi <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Greg Rahn <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Laurel Hale <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-HasComments: Yes

View raw message