impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial
Date Wed, 18 Jan 2017 20:54:13 GMT
Jim Apple has posted comments on this change.

Change subject: Patch references to Cloudera and CDH in Impala tutorial
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5663/1//COMMIT_MSG
Commit Message:

Line 22: I marked with rev="upstream" some <codeblock> tags
I don't see upstream in any ditaval file. Where is it defined?


http://gerrit.cloudera.org:8080/#/c/5663/1/docs/topics/impala_tutorial.xml
File docs/topics/impala_tutorial.xml:

PS1, Line 698: from the sample TPC-DS kit for Impala.
The only one of these is Cloudera's and it was very broken last I checked.


-- 
To view, visit http://gerrit.cloudera.org:8080/5663
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44245b65ce6f247ae8771f582f4b33c3712145ae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message