impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Updates to DML statements for Impala + Kudu
Date Wed, 18 Jan 2017 19:08:44 GMT
John Russell has posted comments on this change.

Change subject: Updates to DML statements for Impala + Kudu
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5646/1/docs/topics/impala_delete.xml
File docs/topics/impala_delete.xml:

Line 49: DELETE [FROM] [<varname>database_name</varname>].<varname>table_name</varname>
[ WHERE <varname>where_conditions</varname> ]
> I think there is another form to describe:
Done


PS1, Line 65:  <p>
            :       Normally, a <codeph>DELETE</codeph> operation for a Kudu table
fails if
            :       some partition key columns are not found, due to their being deleted or
changed
            :       by a concurrent <codeph>UPDATE</codeph> or <codeph>DELETE</codeph>
operation.
            :       Specify <codeph>DELETE IGNORE <varname>rest_of_statement</varname></codeph>
to
            :       make the <codeph>DELETE</codeph> continue in this case. The
rows with the nonexistent
            :       duplicate partition key column values are not removed.
            :     </p>
> I don't think this is relevant anymore (the IGNORE keyword is gone)
Done


Line 101: <!-- To do: investigate if the table reference can actually be a join clause,
to delete from multiple tables at once. -->
> Yes it can, using syntax like:
Done


http://gerrit.cloudera.org:8080/#/c/5646/1/docs/topics/impala_update.xml
File docs/topics/impala_update.xml:

Line 50:   [ WHERE <varname>where_conditions</varname> ]
> similar to my comment on the DELETE, this can support UPDATE with JOIN
Example of the syntax? I get errors trying to put the join clause in different places:

update t1 join t2 on t1.x = t2.x set t1.y = true
          ^
Encountered: JOIN
Expected: SET

update t1, t2
         ^
Encountered: COMMA
Expected: SET


-- 
To view, visit http://gerrit.cloudera.org:8080/5646
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60512b7957fb53d86d3123a4f1d46fbb355f4665
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcryans@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <todd@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message