impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4768: Improve logging of table loading.
Date Mon, 16 Jan 2017 22:32:34 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4768: Improve logging of table loading.
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5709/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:

PS4, Line 327: if (unknownDiskIdCount > 0) {
             :           if (LOG.isWarnEnabled()) {
             :             LOG.warn("Unknown disk id count for filesystem " + fs + ":" +
             :                 unknownDiskIdCount);
             :           }
             :         }
> Do we print for every file? Shouldn't this be outside the while loop?
This was a mistake. Fixed.


PS4, Line 753: Loading
> "Loaded"
Done


http://gerrit.cloudera.org:8080/#/c/5709/3/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

PS3, Line 890: LOG.info("Compiling query: " + queryCtx.client_request.stmt);
> Don't we also want to mark the successful compilation of a query in L926?
For some queries the SQL text can be pretty large, I added the successful compilation msg
without the stmt.


-- 
To view, visit http://gerrit.cloudera.org:8080/5709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8de96d0cb6d09b2272b1925d42cb059367fe7196
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message