impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4768: Improve logging of table loading.
Date Sat, 14 Jan 2017 21:00:55 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4768: Improve logging of table loading.
......................................................................


Patch Set 2: Code-Review+1

(6 comments)

LGTM.

http://gerrit.cloudera.org:8080/#/c/5709/2//COMMIT_MSG
Commit Message:

PS2, Line 10: partiular
nit: typo


http://gerrit.cloudera.org:8080/#/c/5709/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

Line 528:       if (!key.startsWith(Db.FUNCTION_INDEX_PREFIX)) continue;
> I agree. The basic loading steps should be included in the logs.
Thanks Alex.


http://gerrit.cloudera.org:8080/#/c/5709/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

PS2, Line 938:  
...table...


http://gerrit.cloudera.org:8080/#/c/5709/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:

Line 681:     // Map of partition paths to their corresponding HdfsPartition objects. Populated
> I'm not even sure this message is useful. Removed.
Agreed.


Line 1081:   }
> We only get into this code path for INSERT, ALTER TABLE, TRUNCATE TABLE and
Yea I think so. Not too strong about it, I think its fine too.


http://gerrit.cloudera.org:8080/#/c/5709/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

Line 570:     try (MetaStoreClient msClient = catalog_.getMetaStoreClient()) {
> Assuming you mean HDFS tables. The HDFS loading message is a little more de
Makes sense to track the caller, Agreed.


-- 
To view, visit http://gerrit.cloudera.org:8080/5709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8de96d0cb6d09b2272b1925d42cb059367fe7196
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message