impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore in name
Date Fri, 13 Jan 2017 04:46:06 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4757: addendum: avoid double underscore in name
......................................................................


IMPALA-4757: addendum: avoid double underscore in name

Names containing double underscore are implementation-reserved.
E.g. a global macro called __status could in principle be defined
in a C++ system header.

Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
Reviewed-on: http://gerrit.cloudera.org:8080/5702
Reviewed-by: Jim Apple <jbapple-impala@apache.org>
Tested-by: Impala Public Jenkins
---
M be/src/testutil/gtest-util.h
1 file changed, 12 insertions(+), 12 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Jim Apple: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message