impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore prefix
Date Fri, 13 Jan 2017 00:45:54 GMT
Tim Armstrong has uploaded a new patch set (#2).

Change subject: IMPALA-4757: addendum: avoid double underscore prefix
......................................................................

IMPALA-4757: addendum: avoid double underscore prefix

Names starting with double underscore are implementation-reserved.
E.g. a global macro called __status could in principle be defined
in a C++ system header.

Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
---
M be/src/testutil/gtest-util.h
1 file changed, 12 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/5702/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b189fe1ec1e70e19b2fd0ed8b183b7569e5fd05
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>

Mime
View raw message