impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year
Date Thu, 12 Jan 2017 01:29:40 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-4549: consistently treat 9999 as upper bound for timestamp year
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5665/3/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

Line 1483:   TestTimestampValue("cast(253402300799 as timestamp)",
It looks like this is a duplicate of line 1478. Also, can you put these in the same order
as on line 1473? e.g. TestValue(), TestTimestampValue(), TestIsNull()


-- 
To view, visit http://gerrit.cloudera.org:8080/5665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf23b40833017789d879e5da7bb10384129e2d10
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message