impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4341: Add metadata load to planner timeline
Date Wed, 11 Jan 2017 22:55:25 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4341: Add metadata load to planner timeline
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5685/1//COMMIT_MSG
Commit Message:

PS1, Line 13: metata
typo


PS1, Line 15: On successful analysis
what happens on unsuccessful analysis? Doesn't it always have that reference?


Line 20:        - Analysis Requires Metadata Load: 42.972ms (42.972ms)
nit: the other entries seem to start words with lowercase.


http://gerrit.cloudera.org:8080/#/c/5685/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java:

Line 382:       analysisResult_.timeline_ = timeline_;
Move below the next if statement, which checks analyzer is set.


-- 
To view, visit http://gerrit.cloudera.org:8080/5685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f01a35e5f9f5007a0298acfc8e16da00ef99c6c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message