impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4341: Add metadata load to planner timeline
Date Wed, 11 Jan 2017 22:52:25 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4341: Add metadata load to planner timeline
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5685/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java:

Line 64:   // Timeline of important events in the planning process, used for debugging
debugging and profiling


http://gerrit.cloudera.org:8080/#/c/5685/1/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

Line 908:           analysisCtx.getTimeline().markEvent("Analysis Requires Metadata Load");
let's phrase that as an activity, for instance "Metadata load started"


Line 916:             analysisCtx.getTimeline().markEvent("Metadata Load timeout");
"Metadata load" (to go along with existing timeline output)


Line 917:           }
formatting


-- 
To view, visit http://gerrit.cloudera.org:8080/5685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f01a35e5f9f5007a0298acfc8e16da00ef99c6c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message