impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses
Date Wed, 11 Jan 2017 22:14:00 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses
......................................................................


Patch Set 5: Code-Review+2

> I don't fully understand the consequences of not analyzing these
 > exprs. Based on Jim's comment, some parts ofthe code seem to assume
 > that the exprs remain analyzed after rewriting.
 > 
 > Would a more conservative approach be to check if the exprs are
 > analyzed upon entry to the function, then re-analyze them only if
 > they were?

Jim reported the output of a test failure, which is now fixed.

I want to leave it at that for now, the code is convoluted enough as it is.

-- 
To view, visit http://gerrit.cloudera.org:8080/5662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife74c61f549f620c42f74928f6474e8a5a7b7f00
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message