impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient
Date Wed, 11 Jan 2017 21:55:13 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4752: make ObjectPool more efficient
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5666/2/be/src/common/object-pool.h
File be/src/common/object-pool.h:

Line 43:     Element elem{t, [](void* obj){ delete reinterpret_cast<T*>(obj); }};
> That link makes it sound like the braced initialization will still result i
I don't think it matters from a performance perspective - compilers are good at optimising
stack-allocated structs. I just think it ended up being more concise this way.


-- 
To view, visit http://gerrit.cloudera.org:8080/5666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e6a40ac798fa64da4767f530c48710cba623ea5
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message