impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient
Date Wed, 11 Jan 2017 21:35:08 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4752: make ObjectPool more efficient
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5666/2/be/src/common/object-pool.h
File be/src/common/object-pool.h:

Line 43:     objects_.emplace_back(
> It should be able to optimise this fine, since it's a plain struct and it j
That link makes it sound like the braced initialization will still result in a temporary plus
a copy. To get in-place construction it seems to be necessary to define a c'tor. Alternatively
you could use std::tuple, which has a c'tor defined.


-- 
To view, visit http://gerrit.cloudera.org:8080/5666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e6a40ac798fa64da4767f530c48710cba623ea5
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message