impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr
Date Wed, 11 Jan 2017 00:43:16 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr
......................................................................


IMPALA-4707: fix use-after-free in QueryExecMgr

The bug is that the QueryState was referenced after the refcount is
decremented. The fix is to not do that.

Change-Id: I329ff758a0de148a3bdfedc245e56c3a63255535
Reviewed-on: http://gerrit.cloudera.org:8080/5615
Reviewed-by: Dan Hecht <dhecht@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/query-exec-mgr.cc
1 file changed, 15 insertions(+), 17 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Dan Hecht: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I329ff758a0de148a3bdfedc245e56c3a63255535
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message