impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year
Date Wed, 11 Jan 2017 00:35:49 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4549: consistently treat 9999 as upper bound for timestamp year
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5665/1//COMMIT_MSG
Commit Message:

Line 9: Use the patched boost version and update tests accordingly.
> Maybe briefly describe the behavior of Impala before this patch?
Done


http://gerrit.cloudera.org:8080/#/c/5665/1/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

Line 1482:   TestIsNull("cast(cast('9999-12-31 23:59:59' as timestamp) + interval 1 year as
bigint)",
> I think this test would be more interesting if we add 1 second instead. (th
I looked at this again and realised I misunderstood what it was doing.

I think this was a workaround to deal with the fact that we couldn't parse 5-digit years 10000.
We have more extensive edge case tests below in the timestamp tests. I modified one of the
below tests to test + 1 second.


Line 1484:   TestValue("cast(cast('9999-12-31 23:59:59' as timestamp) as bigint)",
> This seems like the base case, put it above the TestIsNull case. (maybe add
Done


Line 1486:   TestTimestampValue("cast(253402300799 as timestamp) - interval 1 year",
> Not sure what this is testing. Maybe remove?
It's testing the int->timestamp reverse conversion. I restructured this to be a bit more
logically organised.


-- 
To view, visit http://gerrit.cloudera.org:8080/5665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf23b40833017789d879e5da7bb10384129e2d10
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message