impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4722: Disable log caching in test scratch disk
Date Tue, 10 Jan 2017 21:37:55 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4722: Disable log caching in test_scratch_disk
......................................................................


Patch Set 2:

> Should we add this to tests/custom_cluster/test_breakpad.py where
 > we also look for logs?
I don't think we need this for the breakpad tests. The tests that actually kill the cluster
trigger a flush of the log files before the process exits. Also, Breakpad forks to write a
minidump and then prints its log messages to stdout and stderr before exiting, which are redirected
into the log files. Therefore it seems that the messages show up in the logs, once the forks
have written the minidumps and terminated (for which we wait in the test).

-- 
To view, visit http://gerrit.cloudera.org:8080/5669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f21284338ee7b4374aca249b6556282b0148389
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message