impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4651: Add LibEv to build
Date Tue, 10 Jan 2017 21:36:19 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4651: Add LibEv to build
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Looks good, looking forward to the follow-up patches when we make use of all of this.

http://gerrit.cloudera.org:8080/#/c/5659/1//COMMIT_MSG
Commit Message:

Line 9: Add libev 4.20 to the Impala build. This is a dependency of KRPC.
Can you mention that the cmake module came from Kudu?


-- 
To view, visit http://gerrit.cloudera.org:8080/5659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf0646533592e6a8cd929a8cb015b83a7ea3008f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message