impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4722: Disable log caching in test scratch disk
Date Tue, 10 Jan 2017 21:08:33 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4722: Disable log caching in test_scratch_disk
......................................................................


Patch Set 1:

(2 comments)

Thanks for the review, please see PS2.

http://gerrit.cloudera.org:8080/#/c/5669/1/tests/common/custom_cluster_test_suite.py
File tests/common/custom_cluster_test_suite.py:

PS1, Line 142: \
> nit: the line continuation shouldn't be necessary inside parentheses. Might
Done


http://gerrit.cloudera.org:8080/#/c/5669/1/tests/custom_cluster/test_scratch_disk.py
File tests/custom_cluster/test_scratch_disk.py:

PS1, Line 86: -logbuflevel=-1
> We should document the importance of this somewhere. Maybe in the comment f
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f21284338ee7b4374aca249b6556282b0148389
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message