impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses
Date Tue, 10 Jan 2017 19:59:06 GMT
Hello Impala Public Jenkins, Dimitris Tsirogiannis,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5662

to look at the new patch set (#2).

Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses
......................................................................

IMPALA-4739: ExprRewriter fails on HAVING clauses

SelectStmt.rewriteExprs() rewrote the pre-analysis form of the HAVING
predicate; the fix was to rewrite the post-analysis version.

SelectStmt.rewriteExprs() is also not effective for the grouping exprs,
but I decided to leave that alone, since it won't result in an error.

The rewriter rule tests are too narrow right now, because they only apply
to select list exprs (which is why it missed the problem with the Having
clause). I added a functional test for this particular jira, but we should
also restructure the rewriter rule tests themselves to apply to all
syntactic elements that can see rewrites.

Change-Id: Ife74c61f549f620c42f74928f6474e8a5a7b7f00
---
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java
M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
4 files changed, 27 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/5662/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife74c61f549f620c42f74928f6474e8a5a7b7f00
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>

Mime
View raw message