impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template
Date Tue, 10 Jan 2017 17:29:42 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4751: Remove blank line from raw_text template
......................................................................


Patch Set 2:

> Why can't this be fixed on the consumer side? Stripping out leading
 > and trailing white space seems a pretty reasonable requirement for
 > parsing this file.

I suppose it can be done on the consumer side, too. Since this used to work and Impala changed
its behavior, it looked like the cleanest approach to me to get the file back into the expected
format.

Do we have documentation on these endpoints where we can explain how to parse them and what
a consumer should expect? Do you think we should hold of on this change and keep the current
behavior instead?

-- 
To view, visit http://gerrit.cloudera.org:8080/5664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b688aa9e2423b0271c8891a983e5b22707d8dbc
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message