impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add Kudu cmake utilities
Date Tue, 10 Jan 2017 05:50:32 GMT
Henry Robinson has posted comments on this change.

Change subject: Add Kudu cmake utilities
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5656/1/CMakeLists.txt
File CMakeLists.txt:

PS1, Line 17: 
            : cmake_minimum_required(VERSION 3.2.3)
> is this installed on our build machines?
The toolchain has cmake 3.2.3.


http://gerrit.cloudera.org:8080/#/c/5656/1/cmake_modules/kudu_cmake_fns.txt
File cmake_modules/kudu_cmake_fns.txt:

Line 18: # Require cmake that can build LLVM [1].
> It would also be good to document the provenance of this file in case someo
Done


PS1, Line 19: 
            : # Note: cmake in thirdparty/ will always meet this minimum.
> this comment doesn't seem to make sense for us either
Done


PS1, Line 27: exported Kudu C++ client
> remove client reference
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaae645d650ab1555452e4cc2574d6c84a90d941
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message