impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4650: Allow protobuf to find non-system libraries and binaries
Date Tue, 10 Jan 2017 01:57:54 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4650: Allow protobuf to find non-system libraries and binaries
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5658/1/cmake_modules/FindProtobuf.cmake
File cmake_modules/FindProtobuf.cmake:

Line 166:         -E env "LD_LIBRARY_PATH=${PROTO_LIB_DIR}:$ENV{LD_LIBRARY_PATH}"
We should really fix the toolchain so that it sets the binary's rpath correctly and none of
this is necessary.

But this works for now (much better than dumping it in impala-config.sh)


-- 
To view, visit http://gerrit.cloudera.org:8080/5658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I942b3f18e25e2abc5aac167412b65abb680d3c5a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message