impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add Kudu cmake utilities
Date Tue, 10 Jan 2017 01:52:03 GMT
Tim Armstrong has posted comments on this change.

Change subject: Add Kudu cmake utilities
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5656/1/cmake_modules/kudu_cmake_fns.txt
File cmake_modules/kudu_cmake_fns.txt:

Line 18: # Require cmake that can build LLVM [1].
> This comment doesn't seem relevant to us.
It would also be good to document the provenance of this file in case someone needs to update
it.


-- 
To view, visit http://gerrit.cloudera.org:8080/5656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaae645d650ab1555452e4cc2574d6c84a90d941
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message