impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4036: show create table outputs invalid SQL for partitioned tables with comments
Date Mon, 09 Jan 2017 23:01:28 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-4036: show create table outputs invalid SQL for partitioned tables
with comments
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5648/1//COMMIT_MSG
Commit Message:

Line 7: IMPALA-4036: show create table outputs invalid SQL for partitioned tables
We always put the description on a single line.


Line 17: Change-Id: Iccf9488e8b1d28fcaf3a40f935157c9dd792812e
Not sure what you did to end up with two Change-Ids. Maybe you squashed two commits together?
I'm guessing this is related to the line after this 'Update code style...', which I'm not
sure what it means.

Either way, you should only have one.


http://gerrit.cloudera.org:8080/#/c/5648/1/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java:

PS1, Line 307:   
Extra spaces.


-- 
To view, visit http://gerrit.cloudera.org:8080/5648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29a33cfd142b473997fdc3acfe3f0966bc7ed784
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: joemcdonnell@cloudera.com
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message