impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads
Date Mon, 09 Jan 2017 19:16:58 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads
......................................................................


IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads

In order to use HDFS hedged reads, the hdfsPread API must be
used instead of the hdfsRead() call. Adds a flag to use
hdfsPread: --use_hdfs_pread

Testing:
* Running existing tests with this flag enabled.
* Cluster testing with HDFS hedged reads enabled via the HDFS
  client config.
* Manually tested setting the 'max_chunk_size' to a small
  value to force multiple iterations of the while loop which
  would only normally happen on S3. Tested reading lineitem
  was OK.

Change-Id: Iecc8b12aa20cbfe08f4ef6a08a191e49709d9525
Reviewed-on: http://gerrit.cloudera.org:8080/5635
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/disk-io-mgr-scan-range.cc
1 file changed, 13 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Matthew Jacobs: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5635
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iecc8b12aa20cbfe08f4ef6a08a191e49709d9525
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message