impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 3.0.5
Date Sun, 08 Jan 2017 18:08:11 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4735: Upgrade pytest in python env to version 3.0.5
......................................................................


Patch Set 1:

I think we should have an exhaustive run here, and I think we should test RHEL7 and Ubuntu.
I also think you need to make sure that we get the same number of tests being run, skipped,
and xfailed to make sure we haven't lost coverage. Last I checked, there were still open pytest
bugs involving marking and skipping, so we don't want one of those to burn us.

Thanks.

-- 
To view, visit http://gerrit.cloudera.org:8080/5640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40d129e0e63ca5bee126bac6ac923abb3c7e0a67
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message